Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test NoExtraThreadAfterEachChange is unstable #5228

Closed
keyboardDrummer opened this issue Mar 21, 2024 · 1 comment · Fixed by #5318
Closed

Test NoExtraThreadAfterEachChange is unstable #5228

keyboardDrummer opened this issue Mar 21, 2024 · 1 comment · Fixed by #5318
Assignees
@keyboardDrummer
Labels
kind: language development speed Slows down development of Dafny the language, flaky tests

Comments

@keyboardDrummer
Copy link
Member

Example flaky failure: https://github.com/dafny-lang/dafny/actions/runs/8374348668/job/22929533710?pr=5214
@keyboardDrummer keyboardDrummer added the kind: language development speed Slows down development of Dafny the language, flaky tests label Mar 21, 2024
@keyboardDrummer keyboardDrummer self-assigned this Mar 21, 2024
@keyboardDrummer keyboardDrummer mentioned this issue Mar 21, 2024
Merged
keyboardDrummer added a commit that referenced this issue Mar 26, 2024
@keyboardDrummer
Flaky tests (#5229)
f2aba48 
### Description
Add extra logging to debug flaky tests

Related issues: #4810,
#5228

### How has this been tested?
Not

<small>By submitting this pull request, I confirm that my contribution
is made under the terms of the [MIT
license](https://github.com/dafny-lang/dafny/blob/master/LICENSE.txt).</small>
@MikaelMayer
Copy link
Member

I hit it again but with a different error

Failed Microsoft.Dafny.LanguageServer.IntegrationTest.Performance.ThreadUsageTest.NoExtraThreadAfterEachChange [740 ms]
  Error Message:
   Assert.InRange() Failure
Range:  (-5 - 5)
Actual: -19
  Stack Trace:
     at Microsoft.Dafny.LanguageServer.IntegrationTest.Performance.ThreadUsageTest.NoExtraThreadAfterEachChange() in

@keyboardDrummer keyboardDrummer mentioned this issue Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keyboardDrummer keyboardDrummer

Labels
kind: language development speed Slows down development of Dafny the language, flaky tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add retries to NoExtraThreadAfterEachChange keyboardDrummer/dafny
2 participants
@keyboardDrummer @MikaelMayer