Fix: Ability to cast a datatype to its trait when overriding functions #4824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…com/dafny-lang/dafny into fix-4823-general-traits-bug-extends
RustanLeino
requested changes
Dec 14, 2023
| @@ -569,6 +569,8 @@ public partial class BoogieGenerator { | |||
| } | |||
| } | |||
|
|
|||
| private int Cutoff = 0; | |||
There was a problem hiding this comment.
It seems this field is not used.
RustanLeino
previously approved these changes
Dec 14, 2023
…com/dafny-lang/dafny into fix-4823-general-traits-bug-extends
…com/dafny-lang/dafny into fix-4823-general-traits-bug-extends
…com/dafny-lang/dafny into fix-4823-general-traits-bug-extends
…com/dafny-lang/dafny into fix-4823-general-traits-bug-extends
…com/dafny-lang/dafny into fix-4823-general-traits-bug-extends
# Conflicts: # Source/DafnyCore/Verifier/BoogieGenerator.Functions.cs # Source/DafnyStandardLibraries/binaries/DafnyStandardLibraries-cs.doo # Source/DafnyStandardLibraries/binaries/DafnyStandardLibraries-go.doo # Source/DafnyStandardLibraries/binaries/DafnyStandardLibraries-java.doo # Source/DafnyStandardLibraries/binaries/DafnyStandardLibraries-js.doo # Source/DafnyStandardLibraries/binaries/DafnyStandardLibraries-notarget.doo # Source/DafnyStandardLibraries/binaries/DafnyStandardLibraries-py.doo # Source/DafnyStandardLibraries/binaries/DafnyStandardLibraries.doo
# Conflicts: # Source/DafnyStandardLibraries/binaries/DafnyStandardLibraries-cs.doo # Source/DafnyStandardLibraries/binaries/DafnyStandardLibraries-go.doo # Source/DafnyStandardLibraries/binaries/DafnyStandardLibraries-java.doo # Source/DafnyStandardLibraries/binaries/DafnyStandardLibraries-js.doo # Source/DafnyStandardLibraries/binaries/DafnyStandardLibraries-notarget.doo # Source/DafnyStandardLibraries/binaries/DafnyStandardLibraries-py.doo # Source/DafnyStandardLibraries/binaries/DafnyStandardLibraries.doo # Source/IntegrationTests/TestFiles/LitTests/LitTest/dafny0/Fuel.legacy.dfy.expect
RustanLeino
approved these changes
Apr 1, 2024
|
Indeed! The fix itself I had originally published got ousted in the merge commit, but at least this PR adds a test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #4823 (but not #4982 yet)
There were two issues there:
I added the corresponding test.
I also ensured that the generation of doo files only use \n lines when creating the source (fixes #4989)
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.