Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Crash using subset type #4724 #4825

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Fix: Crash using subset type #4724 #4825

merged 3 commits into from
Nov 29, 2023

Conversation

jtristan
Copy link
Contributor

Description

Fix for issue #4724

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

@jtristan jtristan linked an issue Nov 28, 2023 that may be closed by this pull request
Crash using subset type #4724
Closed
@jtristan jtristan mentioned this pull request Nov 28, 2023
Closed
@jtristan
Removed erroneous commented-out code.
f4187a9 
Added test file.
Added news file.
@jtristan jtristan enabled auto-merge (squash) November 29, 2023 14:05
MikaelMayer
MikaelMayer approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@MikaelMayer MikaelMayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful!

@jtristan jtristan merged commit ae8b26d into master Nov 29, 2023
20 checks passed
@jtristan jtristan deleted the fix_4724 branch November 29, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikaelMayer MikaelMayer MikaelMayer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash using subset type
2 participants
@jtristan @MikaelMayer