fix: Disambiguation priority not preserved when importing modules #5498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4364.
Description
The author of the issue argues that the types of
xon line 12 and 21 should both be of typeint(currently one is of typeTand one of typeint). I agree that the types should coincide, but believe they should both beTand notint. This is my impression since https://dafny.org/latest/DafnyRef/DafnyRef#483-expression-context-name-resolution indicates that one should look for a datatype constructor before matching a function. I believe the difference between documentation and implementation is due to an incorrect triggering of case 2 if there is no surrounding class (that iscurrentClass is DefaultClassDecl).How has this been tested?
I've added two test files that clarify the initial problem documented in the issue.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.