Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request: Increase responsiveness of formatting by doing it before the resolution phase #3416

Closed
MikaelMayer opened this issue Jan 26, 2023 · 1 comment
Closed

Request: Increase responsiveness of formatting by doing it before the resolution phase #3416

MikaelMayer opened this issue Jan 26, 2023 · 1 comment
Labels
kind: enhancement Enhancements, feature requests, etc. These are NOT bugs, but ways we can improve Dafny part: language server Support for LSP in Dafny (server part; client is in ide-vscode repo)

Comments

@MikaelMayer
Copy link
Member

For the formatter of #3415,
currently, on the Dafny Language server, the parsing and resolution phase are combined. It would be good if we could avoid the resolution phase alltogether and directly format the code after parsing.
@MikaelMayer MikaelMayer added kind: enhancement Enhancements, feature requests, etc. These are NOT bugs, but ways we can improve Dafny part: language server Support for LSP in Dafny (server part; client is in ide-vscode repo) labels Jan 26, 2023
@MikaelMayer MikaelMayer mentioned this issue Jan 26, 2023
Merged
@keyboardDrummer keyboardDrummer changed the title Request: Increasing responsiveness of formatting by doing it before the resolution phase Request: Increase responsiveness of formatting by doing it before the resolution phase Jan 30, 2023
@keyboardDrummer
Copy link
Member

Judging by the call to ParsedProgram, this is already resolved: https://github.com/dafny-lang/dafny/blob/master/Source/DafnyCore/Pipeline/Compilation.cs#L438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind: enhancement Enhancements, feature requests, etc. These are NOT bugs, but ways we can improve Dafny part: language server Support for LSP in Dafny (server part; client is in ide-vscode repo)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@keyboardDrummer @MikaelMayer