Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out why DocumentURI is heterogeneous #2160

Open
MikaelMayer opened this issue May 23, 2022 · 0 comments
Open

Figure out why DocumentURI is heterogeneous #2160

MikaelMayer opened this issue May 23, 2022 · 0 comments
Assignees
@keyboardDrummer
Labels
kind: language development speed Slows down development of Dafny the language, flaky tests misc: cleanup Cleanups in the implementation or in corners of the language

Comments

@MikaelMayer
Copy link
Member

#2148 solves a regression problem, but it looks like the problem might come from a design issue:
VSCode sends DocumentURI that are not obtained through DocumentURI.FromFileSystemPath() but through DocumentURI.Parse() when the code is not stored in a file. However, in our conversion from URI to tokens, we use only the FileSystemPath version.
The language server used to have always relied on files only, so what happened?
See the conversation of #2148 for some pointers.
@MikaelMayer MikaelMayer added the misc: cleanup Cleanups in the implementation or in corners of the language label May 23, 2022
@keyboardDrummer keyboardDrummer added the kind: language development speed Slows down development of Dafny the language, flaky tests label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@keyboardDrummer keyboardDrummer

Labels
kind: language development speed Slows down development of Dafny the language, flaky tests misc: cleanup Cleanups in the implementation or in corners of the language
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@keyboardDrummer @MikaelMayer