-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for OTPs on the Nitrokey Pro? #2
Comments
Hi Robin. In general the answer is yes, I am open to and interested in combining efforts. My main worry is that we cannot have both: raw hidapi style communication as well as integration with |
Good to hear! I’m happy to extend the As far as I see, you are using these commands in
The first two correspond directly to So I am going to add support for enabling and disabling encrypted volumes to the |
@robinkrahl In case you are interested in adding full support for Nitrokey Storage, we would be glad to donate you a device. |
@jans23 That would be great! I can’t make promises regarding the timeline, but I’m definitely interested in porting all |
Sure. I am in a similar boat. I don't have a Nitrokey Pro and my storage device contains actual data, so I have to be careful. But we'll figure something out. |
@d-e-s-o Please write us an email in case you need more hardware. |
@jans23 Sure, thanks for the offer! Right now I am good as I have no new developments in the pipeline. So if Robin is fully covered for his testing that may be enough. I'll see how straightforward the code looks and whether I can get enough coverage with my existing hardware :-) |
I finally finished the work I started this summer and ported the existing
|
That is great news @robinkrahl ! Thanks for working on this. I'll have a look hopefully later today to get a better impression of where you are, by Wednesday at the latest.
We can keep everything on Github. Pull request on the platform should be fine.
Same here. Opening issues should be fine! |
OTP support got merged! Thanks for implementing this feature @robinkrahl . I believe that justifies a new release. I will probably bump to |
Could you wait some days before releasing the next version?
Implementing the remaining commands listed in #4 should be rather easy
now. In any case, we have to update the readme and the man page before
releasing a new version.
|
Sure. I don't want to cram too much into a release and rather release once more, but I also don't want to block progress. |
I’m about to write a command-line tool to generate one-time passwords on my Nitrokey Pro. I already wrote a Rust binding for
libnitrokey
(cratenitrokey
). Before I create yet another Nitrokey CLI tool: Would you be interested in pull requests adding support for one-time password using libnitrokey? (I’m not keen on dealing with the raw hidapi communication, so that would not be an option for me.)The text was updated successfully, but these errors were encountered: