Fix handling of empty user input in pinentry module #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it turns out, the pinentry program responds slightly differently to a request to enter a password/PIN when the user enters one vs. when he/she just continues, leaving the input empty, as is illustrated here: When the user enters 'hello': > $ gpg-connect-agent 'GET_PASSPHRASE --data cacheid errormsg prompt description' '/bye' > D hello > OK When the user enters nothing: > $ gpg-connect-agent 'GET_PASSPHRASE --data cacheid errormsg prompt description' '/bye' > OK So far we always expected a two line response, with the first line containing the 'D ' prefix, which prevents us from handling empty input properly. This change fixes this shortcoming by adding a case for it. Fixes #176
robinkrahl
reviewed
May 2, 2021
robinkrahl
approved these changes
May 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it turns out, the pinentry program responds slightly differently to a
request to enter a password/PIN when the user enters one vs. when he/she
just continues, leaving the input empty, as is illustrated here:
When the user enters 'hello':
When the user enters nothing:
So far we always expected a two line response, with the first line
containing the 'D ' prefix, which prevents us from handling empty input
properly.
This change fixes this shortcoming by adding a case for it.
Fixes #176