Re-evaluate tests::run::version_option test

[robinkrahl]

The tests::run::version_option test is currently disabled because clap used to print the version output directly to stdout. This should be fixed (clap-rs/clap#1390, clap-rs/clap#1602), so we should check whether we can enable this test case.

[d-e-s-o]

I think I checked this not too long ago and my conclusion was that the change is only in the clap 3 branch. So we'll have to wait. Can double check again later today.

[d-e-s-o]

Confirmed the change is not present on v2-master and that the test still fails because data is printed to the real stdout.

--- src/tests/run.rs
+++ src/tests/run.rs
@@ -87,7 +87,6 @@ fn help_options() {
 }

 #[test]
-#[ignore]
 fn version_option() {
   // clap sends the version output directly to stdout: https://github.com/clap-rs/clap/issues/1390
   // Therefore we ignore this test for the time being.
@@ -100,6 +99,8 @@ fn version_option() {

     let s = String::from_utf8_lossy(&out).into_owned();
     let _ = re;
+    use std::io::Write;
+    writeln!(std::io::stdout(), "STDOUT: {}", s);
     assert!(re.is_match(&s), out);
   }

$ cargo test -- version_option --nocapture
running 1 test
nitrocli 0.3.3STDOUT:

thread 'tests::run::version_option' panicked at 'Box<Any>', src/tests/run.rs:104:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
test tests::run::version_option ... FAILED

failures:

failures:
    tests::run::version_option

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 64 filtered out

error: test failed, to rerun pass '--bin nitrocli'

(that is with most recent structopt & clap at the time of writing)

[robinkrahl]

Thanks, I forgot about that. I’ll check whether the patch can be backported to v2.

[robinkrahl]

They consider this to be a feature, not a bug, so no backport for v2.