-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-evaluate tests::run::version_option test #114
Comments
I think I checked this not too long ago and my conclusion was that the change is only in the clap 3 branch. So we'll have to wait. Can double check again later today. |
Confirmed the change is not present on --- src/tests/run.rs
+++ src/tests/run.rs
@@ -87,7 +87,6 @@ fn help_options() {
}
#[test]
-#[ignore]
fn version_option() {
// clap sends the version output directly to stdout: https://github.com/clap-rs/clap/issues/1390
// Therefore we ignore this test for the time being.
@@ -100,6 +99,8 @@ fn version_option() {
let s = String::from_utf8_lossy(&out).into_owned();
let _ = re;
+ use std::io::Write;
+ writeln!(std::io::stdout(), "STDOUT: {}", s);
assert!(re.is_match(&s), out);
}
(that is with most recent |
Thanks, I forgot about that. I’ll check whether the patch can be
backported to v2.
|
They consider this to be a feature, not a bug, so no backport for v2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
tests::run::version_option
test is currently disabled because clap used to print the version output directly to stdout. This should be fixed (clap-rs/clap#1390, clap-rs/clap#1602), so we should check whether we can enable this test case.The text was updated successfully, but these errors were encountered: