Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sections #1

Closed
ebacachu opened this issue Jan 2, 2024 · 8 comments
Closed

Sections #1

ebacachu opened this issue Jan 2, 2024 · 8 comments
Assignees

Comments

@ebacachu
Copy link

ebacachu commented Jan 2, 2024

In the same way that we can export the rivercenterline, could we export the sections?

@cyschneck
Copy link
Owner

What are you referring to when you say sections? Subsections of the river?

@ebacachu
Copy link
Author

ebacachu commented Jan 2, 2024

Intersecting lines
Ag5TUTCizx

@cyschneck
Copy link
Owner

The green line that is circled here is the width line (measuring the width from the right to the left bank)

To return the position of the width line you can use the riverWidthFromCenterline function. This return the width line as a (Longitude, Latitude) : width where the position (Longitude, Latitude) is the position along the centerline (in blue above)

Is that the section information you need?

@cyschneck cyschneck self-assigned this Jan 2, 2024
@ebacachu
Copy link
Author

ebacachu commented Jan 2, 2024

I have seen that riverWidthFromCenterline function. returns (Longitude, Latitude) and width. But with that I can't get the coordinates of the lines, I would need at least two coordinates of each line to define them.
That is, the intersection points of width lines and bank lines could be obtained? This is how each of the width lines would be defined

@cyschneck
Copy link
Owner

You'd like to get the coordinates of where the width line intersects on the left/right bank?

I don't believe I currently have a function in place to get this information (although it is being used on the backend). I will see about adding it today and bundle it with a release

@ebacachu
Copy link
Author

ebacachu commented Jan 2, 2024

I would like to be able to obtain its coordinates from each of the width lines, that is, where it begins and where it ends. Thank you

@cyschneck
Copy link
Owner

New release!

v1.3.0 has the update for riverWidthFromCenterline() with the new option coordinate_reference="Banks". Update also works when the output is saved via save_to_csv with new column headers

Example:

river_width_dict = river.riverWidthFromCenterline(transect_span_distance=transect,
						apply_smoothing=True,
						remove_intersections=True,
						coordinate_reference="Banks",
						save_to_csv=None)

@ebacachu
Copy link
Author

ebacachu commented Jan 3, 2024

Wonderfull, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants