Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup the plugin #14

Closed
cyrilwanner opened this issue Apr 4, 2018 · 0 comments
Closed

Cleanup the plugin #14

cyrilwanner opened this issue Apr 4, 2018 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@cyrilwanner
Copy link
Owner

cyrilwanner commented Apr 4, 2018

The plugin grew quickly which is very nice but it should now be cleaned up/refactored a bit so it still is easy to understand, to maintain and to add more functionality.

  • Split the index.js file into multiple smaller files, maybe one per loader and their options
  • Use babel to use modern js features while still supporting node 6 and to make the code in svg-runtime-generator.js a bit less verbose (use jsx and don't write React.createElement code)
  • Add tests for the newly added functionalities (the new config options, svg sprites and the runtime generator)
  • Add contributing guidelines, issue & pr templates
  • Add code linting

Some feature improvements:

  • if outputPath is specified and relative, make sure it uses the same path on the server & client
  • svg sprites contain all sprites of all pages in the memory of the server, we should only include the sprites on the current page
  • provide a component for the webp fallback
@cyrilwanner cyrilwanner self-assigned this Apr 4, 2018
@cyrilwanner cyrilwanner added the enhancement New feature or request label Apr 16, 2018
@cyrilwanner cyrilwanner added this to the 2.0 milestone Jul 17, 2018
@cyrilwanner cyrilwanner mentioned this issue Nov 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant