-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image optimisation not working with Next 9.1 #113
Comments
Same problem for me and i am using "next": "9.0.0". |
Any solution for this?, I am also facing the same issue |
Same happening here. :/ |
Any update here? Is this library still maintained? |
@cyrilwanner Are you aware of this issue? Is there any way we could help? |
I have since developed and starting using my own solution to embedding images in Next.js projects, in case anyone here finds it useful: https://github.com/humaans/next-img/ |
Yes, there have been even some patches to make it work with the newest next versions and I use it without any problems in my own projects.
No, I didn't encounter this in my own projects. And as I also have some university exams coming up over the next two weeks, I didn't have much time recently to dig much deeper into this or other issues. And the little time I had, I've put into the next major version which will also resolve this issue as it is a complete rewrite. But I would of course still happily accept pull requests (as I've also done over the last few weeks) if someone else wants to look into it. |
Thanks for the clarification, it's great to hear the upcoming version is not far away! Regarding the bug, I don't have time to investigate it for now, I just know @samuelcastro made a PR on our repo using Additional question, will this new version allow to optimise images stored in a CMS/API? (on-the-fly optimisations)? |
I was having the same issue with yarn add next-optimized-images@^3.0.0-canary.0 |
Yes, remote image optimization is one of the new features planned. It isn't already in the current canary version but will be in an upcoming one.
Yes, the canary version should already work and I just published a new one with support for styled-components. So far, it seems to be stable so as soon as I have implemented all missing features from the current version, I'll release it on the non-canary tag. |
@cyrilwanner Any updates on this? When will it be finally release along with the on-the-fly optimizations? Thanks! |
I import an image like so:
My config is:
The
?resize
does it's job, it outputs images for each required size. Butimagemin-optipng
(which is installed) is definitely not applying any optimisations since the build finishes quickly. If I run optipng manually it takes several minutes and reduces sizes of the images.If I log
JSON.stringify(_arguments)
inimagemin-optipng/index.js
I see this logged twice, althought I have dozens of images:I don't know if those nulls are just how
exec-buffer
is meant to work, or if that's another issue.The text was updated successfully, but these errors were encountered: