Close mutation editor on submission

[wxtim]

Describe exactly what you would like to see in an upcoming release

[edit] updated, see comments bellow

• Remove the old task icon status thinggy (was never intended to be released). (graph view and central data store #1108)
• Make the dialogue box close on successful submission of a mutation. (Edit runtime (deconflicted) #1160)
• Keep the dialogue box open for an unsuccessful submission and raise an Alert (if not already done). (Edit runtime (deconflicted) #1160)
• Add a close "x" button to the top right of the mutation editor form, as well as the mutation menu Pin the action button ("submit", "cancel" etc) to the bottom of the form so they're visible at all times (Feature mutation form sticky buttons #1428)

[/edit]

The following dialog is fully functional but some users may find having to close with the cancel button confusing.

In my opinion these dialogs should have a cross which copies the functionality of the cancel button at either the top right or top left corner.

Pull requests welcome!

[hjoliver]

I agree. "Cancel" could easily be confused with trying to cancel the mutation you've just submitted.

[oliver-sanders]

The box should close once the mutation has been submitted.

At the moment it doesn't for debug purposes, I think when you submit a mutation you still get a task icon showing the status of the mutation (i.e. waiting, submitted or submit-failed).

Propose the following:

• Remove the old task icon status thinggy (was never intended to be released).
• Make the dialogue box close on successful submission of a mutation.
• Keep the dialogue box open for an unsuccessful submission and raise an Alert (if not already done).

[oliver-sanders]

Two likes no screams, removing the question label.

[MetRonnie]

The mutation menu could also do with an "x" close button, because for small viewports there is likely to barely be any room to tap outside the menu in order to close it. I have added this (and the close button for the mutation editor form) as a bullet point

[oliver-sanders]

(alternatively ensure the cancel button is always visible e.g. via a sticky footer)

[oliver-sanders]

Suggest putting the submit and cancel buttons in a sticky footer at the bottom of the form so they are always visible as this will also be useful for the submit button (we don't always need to scroll to the bottom).

[oliver-sanders]

Note this will likely be closed by #1144

They did for edit-runtime dialog. I need to check they do for others/