Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alert: error icon looks like close button #1127

Closed
oliver-sanders opened this issue Oct 27, 2022 · 2 comments · Fixed by #1218
Closed

alert: error icon looks like close button #1127

oliver-sanders opened this issue Oct 27, 2022 · 2 comments · Fixed by #1218
Assignees
@wxtim
Labels
good first issue Good for newcomers small UX/UI User experience and interface improvements
Milestone
1.5.0

Comments

@oliver-sanders
Copy link
Member

The error icon in alerts looks somewhat like a close icon:

Screenshot 2022-10-27 at 16 08 26

Suggest using something like ⚠️, ⛔️ or 😞.

Pull requests welcome!
This is an Open Source project - please consider contributing a bug fix
yourself (please read CONTRIBUTING.md before starting any work though).
@oliver-sanders oliver-sanders added the UX/UI User experience and interface improvements label Oct 27, 2022
@MetRonnie MetRonnie added good first issue Good for newcomers small labels Nov 10, 2022
@MetRonnie
Copy link
Member

IMO we should also replace the whole error bar with a snackbar (toast-like pop-up). This is already in use for the Edit Runtime form (#1160).

The problem with the current error bar is it causes a downward shift of the open view.

@oliver-sanders
Copy link
Member Author

I'd be happy to re-work the Alert component to use a snackbar. We should push the edit-runtime alerts through this system when done.

@MetRonnie MetRonnie added this to the 1.x milestone Jan 4, 2023
@wxtim wxtim self-assigned this Jan 5, 2023
@wxtim wxtim mentioned this issue Jan 5, 2023
Closed
6 tasks
@MetRonnie MetRonnie mentioned this issue Jan 19, 2023
Merged
6 tasks
@MetRonnie MetRonnie modified the milestones: 1.x, 1.5.0 Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wxtim wxtim

Labels
good first issue Good for newcomers small UX/UI User experience and interface improvements
Projects
None yet
Milestone
1.5.0
Development

Successfully merging a pull request may close this issue.

Replace alert bar with snackbar MetRonnie/cylc-ui
replace alert with snackbar wxtim/cylc-ui
3 participants
@oliver-sanders @wxtim @MetRonnie