Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger edit replacement - "Edit Runtime" #1104

Closed
MetRonnie opened this issue Sep 15, 2022 · 5 comments · Fixed by #1160
Closed

Trigger edit replacement - "Edit Runtime" #1104

MetRonnie opened this issue Sep 15, 2022 · 5 comments · Fixed by #1160
Assignees
Milestone

Comments

@MetRonnie
Copy link
Member

MetRonnie commented Sep 15, 2022

As discussed in cylc/cylc-flow#3751, implement the front-end of trigger-edit capability. This will take the task's [runtime] info from GraphQL (cylc/cylc-flow#5054) and display it as a form, allowing user to add/remove/edit fields (but not the inherit field).

@MetRonnie MetRonnie added this to the 1.x milestone Sep 15, 2022
@MetRonnie MetRonnie self-assigned this Sep 15, 2022
@hjoliver
Copy link
Member

A note, offline, from one of our main sites:

our most common edit run is to change a line that looks like:
rose task-run arg1 arg2 arg3
to
rose task-run arg1 arg2 arg3 –new
To force something to re-run from scratch (for example if the model was unstable)

Probably stating the obvious at this point, but the script items will need text-edit capability, potentially for a large amount of scripting.

@hjoliver
Copy link
Member

hjoliver commented Oct 17, 2022

What did we decide to rename this capability to, now that "trigger edit" and "edit run" are no longer appropriate (triggering will be separate)?

  • stick with broadcast, for former use cases of that and for the more restricted one-off "edit run" style use?
    • this name is a fairly obtuse reference to the idea of "broadcasting" new settings to tasks via the scheduler, but it might not be so obvious to users
  • set-runtime or task-runtime?
  • override?
  • ???

@hjoliver
Copy link
Member

Note security concerns here: cylc/cylc-flow#2687 (comment)

Initially, I guess we can just make sure cylc broadcast as a whole defaults to the most restrictive authorization level.

Later we might need to consider singling out script and environment items as more dangerous.

@MetRonnie
Copy link
Member Author

What did we decide to rename this capability to, now that "trigger edit" and "edit run" are no longer appropriate (triggering will be separate)?

I had settled upon "Edit Runtime", but open to suggestions

@hjoliver
Copy link
Member

Right, thanks, I recall that from the meeting now. "Edit Runtime" is quite good - it is descriptive and it's reminiscent of the original "edit run" description of "trigger --edit".

We should consider changing the CLI command name cylc broadcast to cylc edit-runtime too. (We can provide an alias to the old name, of course).

@MetRonnie MetRonnie changed the title Trigger edit Trigger edit replacement - "Edit Runtime" Oct 19, 2022
This was referenced Nov 18, 2022
@oliver-sanders oliver-sanders linked a pull request Dec 12, 2022 that will close this issue
6 tasks
@dpmatthews dpmatthews modified the milestones: 1.x, 1.4.0 Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants