Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cycleway:*:oneway #119

Closed
Phyks opened this issue Apr 15, 2019 · 12 comments
Closed

Support cycleway:*:oneway #119

Phyks opened this issue Apr 15, 2019 · 12 comments
Assignees
Labels
enhancement An already rendered feature which should be improved.
Milestone

Comments

@Phyks
Copy link
Member

Phyks commented Apr 15, 2019

We are currently supporting oneway tag on highway=cycleway. The same scheme should be extended to support cycleway:left|right:oneway=no.

@Phyks Phyks added the enhancement An already rendered feature which should be improved. label Apr 15, 2019
@Florimondable
Copy link
Member

Please don't add on default cycleway (so oneway) an arrow.

@Phyks
Copy link
Member Author

Phyks commented May 24, 2019

Please don't add on default cycleway (so oneway) an arrow.

We are already doing it on highway=cycleway + oneway=yes: https://cyclosm.github.io/cyclosm-cartocss-style/example.html#18/48.82399/2.32594.

@Florimondable
Copy link
Member

Florimondable commented May 24, 2019

And I'm the guy who did that.

@Phyks Phyks added this to the v0.3 milestone Oct 4, 2019
@Phyks
Copy link
Member Author

Phyks commented Oct 7, 2019

I'm not sure what to do with this. Most of the cycleway:left|right:oneway are living on lane or share_busway. We render these with dots and I'm not sure it would be really nice to have an arrow on top of the dots.

@Florimondable what do you think about using a pattern on the casing to have a very slight arrow for the direction? Something like (very subtle)

2019-10-07-174511

Track would keep the arrow just as a separate highway=cycleway would (but tracks are a minority in this scheme, about 1k worldwide).

@Florimondable
Copy link
Member

That's smart !

But never felt the need to have that feature, so is it necessary for me ? No.
Though I know some weird cases where it would be good to know the the direction of the lane https://www.google.fr/maps/@48.8435905,2.4577221,3a,75y,301.05h,73.66t/data=!3m6!1e1!3m4!1sHSKW06zdC09DvA2lZ6ROrA!2e0!7i16384!8i8192
(The openstreetmap on that case is not good in my opinion.)

@Phyks Phyks self-assigned this Oct 8, 2019
@Phyks
Copy link
Member Author

Phyks commented Oct 14, 2019

Here is my current render at Z18 and beyond.

https://www.cyclosm.org/#map=19/48.84960/2.36974

2019-10-14-132450

https://www.cyclosm.org/#19/48.79724/2.15395

2019-10-14-132952

https://www.cyclosm.org/#map=18/48.82589/2.32857/cyclosm

2019-10-14-134309

Left to do:

  • cycleway:*:oneway=no
  • cycleway:left|right=track

@Phyks
Copy link
Member Author

Phyks commented Oct 14, 2019

Bidirectional cycleways tagged on main highway are now larger as well.

https://www.cyclosm.org/#map=18/48.80099/2.43625/cyclosm

2019-10-14-150801

@Phyks
Copy link
Member Author

Phyks commented Oct 14, 2019

Done for tracks. https://www.cyclosm.org/#map=18/48.82637/2.32988

2019-10-14-161321

@Phyks Phyks closed this as completed Oct 14, 2019
@Florimondable
Copy link
Member

not sure to understand why this one is not rendered oriented https://www.openstreetmap.org/way/64609509 but this one is https://www.openstreetmap.org/way/25469382
https://www.cyclosm.org/#map=20/48.87709/2.36359/cyclosm

@Phyks
Copy link
Member Author

Phyks commented Oct 18, 2019

I'm only rendering cycleway:left|right:oneway and cycleway:left|right=opposite_* so far. You are right, I should include direction for these as well.

We just have to be careful about cycleway:both=* for which we should not render any arrows (depends on left or right hand side driving). I'd still render an arrow for cycleway=* to make the distinction clear and improve tagging.

@Phyks Phyks reopened this Oct 18, 2019
@Phyks Phyks modified the milestones: v0.3, v0.4 Oct 18, 2019
@Florimondable
Copy link
Member

You are right, I should include direction for these as well.
I didn't say that, it was just to understand.
Nevertheless may be we should render them, didn't think it through yet.

@Phyks
Copy link
Member Author

Phyks commented Dec 1, 2019

I think everything is fine for this in the code currently. Reopen if I missed anything.

@Phyks Phyks closed this as completed Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An already rendered feature which should be improved.
Projects
None yet
Development

No branches or pull requests

2 participants