Adds support for strict flat type mapping #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All non-namespaced classes in JsonMapperTest are made part of the PSR0 autoloading. Exception still made for the "Zoo" collection of classes.
We do not need to check for this version anymore
Was never verified using the non-existing second parameter of expectException()
The tests never check if they contain anything
Resolves: cweiske#232
Only handle objects as array when they implement both ArrayAccess and Traversable. BC break! ---- Originally, JsonMapper handled objects extending ArrayObject as arrays. Extending own collection classes from ArrayObject is not always feasible (issue cweiske#175, cweiske#175), so a way was sought to rely on interfaces only. Patch cweiske#197 (cweiske#197) changed the implementation to check for the ArrayAccess interface instead of ArrayObject. This unfortunately breaks objects-that-allow-array-access-but-are-not-traversable-arrays (issue cweiske#224, cweiske#224), for example when you allow array access to properties stored in some internal variable. The correct solution is to check that the object implements ArrayAcces *and* Traversable - then we can be sure the object is intended to be used with e.g. foreach(). Resolves: cweiske#224
In addition to "int|null", JsonMapper now also supports "?int"
- a syntax that was added to PHP in versino 7.1.0
("Nullable type syntactic sugar").
Resolves: cweiske#235
Simple types like strings in arrays that expect an object will throw an exception now when bStrictObjectTypeChecking is enabled. BC break! Resolves: cweiske#225
SvenRtbg
suggested changes
Jul 15, 2024
| case 'string': return $jType === 'string'; | ||
| case 'bool': return $jType === 'boolean'; | ||
| case 'int': return $jType === 'integer'; | ||
| case 'float': return $jType === 'double' || $jType === 'float' || $jType == 'integer'; |
There was a problem hiding this comment.
gettype() does not return "float" according to php.net
| case 'bool': return $jType === 'boolean'; | ||
| case 'int': return $jType === 'integer'; | ||
| case 'float': return $jType === 'double' || $jType === 'float' || $jType == 'integer'; | ||
| case 'null': return $jType === 'null' || $jType === 'NULL'; |
There was a problem hiding this comment.
gettype() only returns "NULL"
| * type as the given json type | ||
| * | ||
| * @param $classType | ||
| * @param $jType |
There was a problem hiding this comment.
As much as I personally don't like PHPDoc anymore (preferring explicit types), the minimum here would be giving the types for the parameters.
| throw new JsonMapper_Exception( | ||
| 'JSON property "' . $key . '" in class "' | ||
| . $strClassName . '" is of type ' . gettype($jvalue) . ' and' | ||
| . ' cannot be converted to ' . $type |
There was a problem hiding this comment.
It isn't about "cannot", but "will not" or "should not", because the code that literally does it is on line 269/284 below.
| * | ||
| * @var bool | ||
| */ | ||
| public $bStrictFlatTypes = false; |
There was a problem hiding this comment.
Yeah, another flag... which effectively requires doubling all test cases except the ones that are obviously failing their test case long before this strict flat type phase would be reached.
|
@esdraelon Will you provide unit tests for the new flag? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for strict flat type mapping via $bStrictFlatTypes