Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/item and /give tries to spawn technical blocks, resulting in client crash #89

Closed
mathiascode opened this issue Oct 6, 2014 · 4 comments · Fixed by #111
Closed

/item and /give tries to spawn technical blocks, resulting in client crash #89

mathiascode opened this issue Oct 6, 2014 · 4 comments · Fixed by #111

Comments

@mathiascode
Copy link
Member

Whenever I try to give myself technical blocks on my server (for example the Bed Block, ID 26), the client crashes as technical blocks don't exist in item form anymore since 1.7. If I'm correct, 1.6 support for MCServer was removed recently, so is there a possibility to remove those items from the item list the /item and /give commands use?

I allow people on my server to use these commands, and some of them may try to get technical blocks, without knowing that their clients will crash.

@madmaxoft
Copy link
Member

How does Vanilla handle that - can you give yourself the invalid item? Does it have any kind of blacklist?

@mathiascode
Copy link
Member Author

In 1.7 Vanilla, when I try to give myself technical blocks with the /give command, it gives an error saying "There is no such item with ID X".

@bearbin
Copy link
Member

bearbin commented Oct 6, 2014

Maybe make blocking the technical stuff the default and have a unsafegive
command?

@madmaxoft
Copy link
Member

I think the easiest solution would be to implement a (configurable) blacklist of givable items, /give would consult the blacklist before giving the item and if we ever need to give the unsafe items, then the /unsafegive command is a good option. I was thinking about having an argument for /give that would disable the blacklist, but that's somewhat problematic if ever the vanilla command receives other parameters, we want to be as compatible as possible.

Any Lua coders up to this task? It should be relatively easy.

This was referenced Dec 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants