Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting codes do not work #84

Open
Masy opened this issue Aug 11, 2014 · 17 comments
Open

Formatting codes do not work #84

Masy opened this issue Aug 11, 2014 · 17 comments

Comments

@Masy
Copy link

Masy commented Aug 11, 2014

Color codes work fine but the formatting codes don't work.
-> https://minecraft.gamepedia.com/Formatting_codes

@worktycho
Copy link
Member

Looks like a bug in the server not core. Possibly related to cuberite/cuberite#852

@madmaxoft
Copy link
Member

The server itself uses the at-sign (@) for color-codes, which is kinda stupid because that's a rather common character. People have been saying they want it changed to the and-sign (&), but that conflicts with most parameterized URLs.

@worktycho
Copy link
Member

Which issue is that, because I'd like to suggest we use \a.

@madmaxoft
Copy link
Member

A backslash for formatting codes? That's new. It'd be somewhat nerve-wrecking in code - it has to be escaped, which is often forgotten. But otherwise that could work. The only thing I can think of using backslashes is Windows path separator.

@worktycho
Copy link
Member

No as in the bell character. Or any of the other effectively obsolete ASCII charicters: Start Of Heading, Start Of Text, End Of Text, End Of Transmission, Enquiry, Acknowledge, backspace, Vertical Tab, Form Feed, ... Theres loads of characters below char 32 which aren't used any more.

@madmaxoft
Copy link
Member

But those can't be typed on a keyboard.

@worktycho
Copy link
Member

But if they're only used internally then we can just use the escape sequences. For anything exposed we should use the same as the client.

@madmaxoft
Copy link
Member

The point is that they're exposed.

@worktycho
Copy link
Member

Then why aren't we using the same char as vanilla, any character that is on a keyboard will have the same problem as @?

@bearbin
Copy link
Member

bearbin commented Aug 11, 2014

Well Bukkit normally uses &, but I don't think I've ever used my ¬ character.

@worktycho
Copy link
Member

I'm pretty sure I have, I don't think there a single key on my key board I haven't used at least once.

@NiLSPACE
Copy link
Member

I don't have that character on my keyboard though.

@Masy
Copy link
Author

Masy commented Aug 11, 2014

me either, i think & or @ are the best solutions...

@bearbin
Copy link
Member

bearbin commented Aug 11, 2014

I'd say go with & then, because it's what bukkit stuff uses.

But make sure to add && as an escape, and only convert it to a colour code when it's followed by one of the right nums/letters.

@Masy
Copy link
Author

Masy commented Aug 11, 2014

Also you shouldn't be scared of broken links, the colores are just visual, minecraft converts it into colors so links still work...

@tigerw
Copy link
Member

tigerw commented Aug 11, 2014

The bell character is used. Command Prompt screams beeps at you if you feed it a bell.

@worktycho
Copy link
Member

@tigerw When was the last time you used a bell in a piece of text? My comment still stands about the others

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants