Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not call functions from ExternalModules directly #7

Closed
ChemiKyle opened this issue Jan 29, 2020 · 2 comments
Closed

Do not call functions from ExternalModules directly #7

ChemiKyle opened this issue Jan 29, 2020 · 2 comments
Assignees
@jrpence @ChemiKyle

Comments

@ChemiKyle
Copy link
Contributor

See official documentation and issue.

Recommend something like sed s/ExternalModules::/$this->/g to correct but each line will need to be inspected.
@ChemiKyle ChemiKyle self-assigned this Jan 29, 2020
@ChemiKyle ChemiKyle mentioned this issue Jan 30, 2020
Merged
@jrpence jrpence self-assigned this Aug 5, 2020
@jrpence
Copy link

jrpence commented Aug 5, 2020

look like it was already addressed.. d18c4d0
there was just one use statement left over though...

@ChemiKyle
Copy link
Contributor Author

Indeed, I don't see any meaningful results with grep -r . -e '::' so I'll close this issue.
Sorry for the non-existent goose chase!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrpence jrpence

@ChemiKyle ChemiKyle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jrpence @ChemiKyle