Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize the module for Framework 5 and higher #16

Closed
pbchase opened this issue Dec 11, 2023 · 2 comments
Closed

Modernize the module for Framework 5 and higher #16

pbchase opened this issue Dec 11, 2023 · 2 comments

Comments

@pbchase
Copy link
Contributor

pbchase commented Dec 11, 2023

I attempted to update the framework version, but the code failed. The issue I found was when upgrading to Framework Version 5 and higher. It appears the changes to getProjectSettings() in that Framework prevent the module from getting its settings.
@pbchase
Copy link
Contributor Author

pbchase commented Dec 11, 2023

This feels like a change you'd coordinate with PR #11 as each requires an overhaul of the project settings code

@ChemiKyle ChemiKyle mentioned this issue Mar 19, 2024
Merged
@pbchase
Copy link
Contributor Author

pbchase commented May 24, 2024

Addressed by PR #17

@pbchase pbchase closed this as completed May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pbchase