Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preranked metric ties #18

Open
ToledoEM opened this issue Feb 6, 2018 · 4 comments
Open

Preranked metric ties #18

ToledoEM opened this issue Feb 6, 2018 · 4 comments
Assignees

Comments

@ToledoEM
Copy link
Contributor

ToledoEM commented Feb 6, 2018

Hi, great package.
I am wondering how it is manage when the metric of the ranked genes it is a tie, this for values not equal to 0.

The Broad Institute java software has a warning about this, but I did not find any information about it in the preprint nor the vignette.

Should ties be solve with jittering the duplicated values? or a warning be printed when there are ties in the ranked gene list?

@assaron
Copy link
Member

assaron commented Feb 6, 2018

Hi,

For now ranking ties are not properly supported and I guess the behavior is pretty similar to Broad's. While the results could be somewhat errorneous, I don't think it really matters in most circumstances. Moreover, there is no point in jittering, the current behaviour is equivalent to jittering ("he order of genes will be arbitrary").

I had a similar request recently and I think I know how to properly deal with it, but don't have time to implement it yet.

@ToledoEM
Copy link
Contributor Author

ToledoEM commented Feb 6, 2018

Hi,
You are right about jittering, same output.
Maybe a warning should be enough.
Thanks

@ToledoEM ToledoEM closed this as completed Feb 6, 2018
@assaron
Copy link
Member

assaron commented Feb 6, 2018

I'll keep the issue open until it's resolved properly.

@mayanbriller
Copy link

Hi!
I am also having this problem.
I think it originates from using something like p-values (for me) as a ranking metric in a pre-ranked gene list.
In the original GSEA you can choose to do a weighted analysis (under enrichment statistic) or 'classic' - which is the right one to choose when using a metric like p-value (where the actual value doesn't matter I guess)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants