Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.5.2 release is not working correctly when installed from npm #265

Closed
domakas opened this issue Jan 25, 2016 · 1 comment
Closed

1.5.2 release is not working correctly when installed from npm #265

domakas opened this issue Jan 25, 2016 · 1 comment

Comments

@domakas
Copy link

domakas commented Jan 25, 2016

It seems that npm release tarball http:https://registry.npmjs.org/csso/-/csso-1.5.2.tgz and github release tarball https://github.com/css/csso/archive/v1.5.2.tar.gz are different. In particular when optimizing with npm release version lots of bulk data is outputted to console. This is done in particular with one method:

// File: csso/lib/compressor/restructure/markShorthands.js
TRBL.prototype.isOkToMinimize = function() {
    //...//
            console.log(values); // <-- line 194
    //...//
};

I'm not able to find anything in git history regarding this, and 1.5.1 release seem to have correct behavior.

I have no idea how to solve this, maybe try to create new release or something like updating npm registry. However this causes thousands of lines outputted in build log, which is then unreadable :(

@lahmatiy
Copy link
Member

Thank you for notice. You're right, one of modules was published in development state.
I've published 1.5.3. Should be ok now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants