Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Improvement) Tests needed for bug in version 1.4.0 #247

Closed
cnole opened this issue Oct 22, 2015 · 2 comments
Closed

(Improvement) Tests needed for bug in version 1.4.0 #247

cnole opened this issue Oct 22, 2015 · 2 comments

Comments

@cnole
Copy link

cnole commented Oct 22, 2015

We used csso through gulp-csso to minify our CSS and we rolled out a release on Monday (19/10/2015). Unfortunately there was a bug in csso version 1.4.0 which was used to build the release. The bug is reproducible:

echo ".test { color: #000; } .test * { color: #fff; }" | ./csso

which produces the following output:

.test{color:#000}.test*{color:#fff}

As you can see the whitespace before the wildcard selector "*" was removed, that is wrong output and can be very dangerous because the whole cascading styles under ".test" are lost.

The version 1.4.1 produces the following output which is exactly i would expect:

.test{color:#000}.test *{color:#fff}

I appreciate a lot that you have fixed this bug so quickly in version 1.4.1. Could you please write some tests for this case so that this won't happen again?

@lahmatiy
Copy link
Member

It was added with fix, see commit dd8709e

@cnole
Copy link
Author

cnole commented Oct 22, 2015

@lahmatiy My Bad, i didn't see the commit. Thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants