-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structural optimization fails on browser hacks #231
Comments
@asapach you beat me to it... I'm seeing this too |
Same here. Finally tracked the missing Bootstrap caret to CSSO. (Fabulous package otherwise!) Toggling structural optimization to false unsurprisingly solves the problem (and surprisingly results in a smaller CSS file). |
I also came across this problem. As jmcmichael said, setting structural optimization to false fortunately fixes this problem. |
Fixed by #166 |
+1 |
@lahmatiy Sure this is fixed? I'm a strong believer in "What ain't tested, ain't working" :) and PR #166 does not include any unit test
The PR integration is probably the cause: look at https://github.com/css/csso/blob/v1.3.12/lib/compressor.js#L125 vs https://github.com/css/csso/pull/166/files#diff-e83fb3368ebbc864f774279d085ac1a8R124 |
Thank you for your feedback. |
I see it's another issue now. It's connected with wrong structural optimisation. |
Reproducible on Bootstrap 3.3.5:
Optimized:
The IE8 browser hack breaks the other declaration.
The text was updated successfully, but these errors were encountered: