-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Including optional shard installation #7
Comments
Hi. I may be opposed to adding even more extra features. E.g. And, some thought needs to be given regarding what to cache. E.g. https://oprypin.github.io/install-crystal/configurator.html suggests 2 styles: cache Finally, a pull request. It would be good, thanks. Although, I am likely to be picky regarding the approach. In other case, eventually I will get around to this myself. |
First of all, thank you for providing this amazing GitHub Action! It's been a really great addition to my CI workflows.
Something I've found a lot of value in with the
ruby/setup-ruby
action is the ability to runbundle install
and cache the gems as a part of the action with thebundler-cache: true
option.Is something like a
shards-cache: true
option something that the maintainers would be open to as a part of this action? I haven't worked with writing GitHub actions before, so I wanted to make sure there was an appetite to review a PR before taking the time to learn and implement one.This would reduce the common copy-and-paste that I do to every Crystal project, which generally does these steps every time:
My hope would be that these steps could be reduced to (naming TBD):
Or, if you didn't use something like Ameba and didn't do matrix testing against old Crystal versions, something as simple as:
The text was updated successfully, but these errors were encountered: