Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Review documentation for "in-place" / "overlapping" operations. #397

Open
duesee opened this issue Apr 12, 2023 · 3 comments
Open
Labels
documentation 🗒 Improvements or additions to documentation

Comments

@duesee
Copy link
Contributor

duesee commented Apr 12, 2023

Some functions are allowed to be called with overlapping memory but the documentation does not always specify that. Example: Ed25519::secret_to_public.

@duesee duesee added the documentation 🗒 Improvements or additions to documentation label Apr 12, 2023
@ma-ilsi
Copy link
Contributor

ma-ilsi commented Oct 12, 2023

Some functions are allowed to be called with overlapping memory ... Example: Ed25519::secret_to_public.

I just looked at line 25 of the hacl-star source and I think public_key and private_key should not overlap.

Did you mean:

Some functions are not allowed to be called with overlapping memory

Would it also be helpful to slightly improve the documenting comments so the the Params and Returns headings can render when they are converted to docs?
As an example compare the aesthetic look EdDSA against the organized RSAPSS:

Screen Shot 2023-10-12 at 11 06 52 AM Screen Shot 2023-10-12 at 11 07 00 AM

@franziskuskiefer
Copy link
Member

Would it also be helpful to slightly improve the documenting comments so the the Params and Returns headings can render when they are converted to docs?

Yeah I agree. The RSA docs are way nicer to read. Organising them would be great.
Again, this needs to be done on the hacl-star side.

@ma-ilsi
Copy link
Contributor

ma-ilsi commented Nov 8, 2023

Okay great. Thanks for the green light 🚦.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 🗒 Improvements or additions to documentation
Projects
Status: Triage Needed
Development

No branches or pull requests

3 participants