Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refer to (new) Hacl_HMAC_DRBG_free and fix duplicate documentation. #298

Merged
merged 4 commits into from
Dec 7, 2022
Merged

Refer to (new) Hacl_HMAC_DRBG_free and fix duplicate documentation. #298

merged 4 commits into from
Dec 7, 2022

Conversation

duesee
Copy link
Contributor

@duesee duesee commented Dec 6, 2022

This closes #296.

@duesee duesee requested a review from a team as a code owner December 6, 2022 18:27
@cla-bot cla-bot bot added the cla-signed label Dec 6, 2022
@coveralls
Copy link

coveralls commented Dec 6, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3637771432

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 55.949%
Totals Coverage Status
Change from base Build 3631490752: 0.01%
Covered Lines: 33744
Relevant Lines: 60312
💛 - Coveralls

franziskuskiefer
franziskuskiefer requested changes Dec 6, 2022
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, let's use this instead of free_state in the tests as well.

@duesee
Copy link
Contributor Author

duesee commented Dec 6, 2022

Oh, good catch.

franziskuskiefer
franziskuskiefer approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Looks like a Rust job is failing though.

@duesee
Update config/default_config.cmake.
eb05da7 
```sh
cp build/config.cmake config/default_config.cmake
```
@duesee duesee merged commit 845e63e into main Dec 7, 2022
@duesee duesee deleted the duesee/issue_296 branch December 7, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franziskuskiefer franziskuskiefer franziskuskiefer approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: Refer to (now available) Hacl_HMAC_DRBG_free.
3 participants
@duesee @coveralls @franziskuskiefer