CI: Verify and cleanup jobs. #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jul 7, 2022
Closed
franziskuskiefer
requested changes
Jul 7, 2022
There was a problem hiding this comment.
Thanks, looks much better already.
A couple nits and questions inline and some general points below.
- Please link Fix windows --msvc 32-bit build in CI. #92 and disable the failing job
- Document CI in book
- Naming of the upload artefacts appears to be broken for some jobs, e.g.
aarch64-linux-android-${SHORT_SHA},linux-default-${SHORT_SHA},linux-s390x-gcc10-${SHORT_SHA}
This was referenced Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the CI to run more jobs, i.e., using different compilers, compiler versions, and flags. It is also an attempt to make the CI more readable by giving every step a name and extracting common functionality into local actions.