Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allowed hash algorithms for RSASSA-PSS. #100

Open
duesee opened this issue Jul 11, 2022 · 1 comment
Open

Allowed hash algorithms for RSASSA-PSS. #100

duesee opened this issue Jul 11, 2022 · 1 comment
Labels
api

Comments

@duesee
Copy link
Contributor

duesee commented Jul 11, 2022

Currently, Hacl_RSAPSS_rsapss_* uses Spec_Hash_Definitions_hash_alg which defines multiple hash algorithms that are not implemented (nor should be) for RSASSA-PSS.
@duesee duesee mentioned this issue Jul 11, 2022
Merged
@protz
Copy link
Collaborator

protz commented Jul 20, 2022

Is there a precondition in the original source code that statically rules out some values for the hash algorithm? If so, two options:

  • add a layer with a "defensive" API that can return an error along the lines of NOT_SUPPORTED
  • suitable comments in the source that propagate to the C

@duesee duesee added the api label Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api
Projects
HACL Packages
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@protz @duesee