Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix anacron build when obstack not available #64

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Fix anacron build when obstack not available #64

merged 1 commit into from
Aug 3, 2020

Conversation

kadler
Copy link
Contributor

@kadler kadler commented Aug 3, 2020

Neither musl nor AIX (and likely other non-GNU systems) provide the
obstack interface used by anacron. To work around this, include a copy
of obstack.c and obstack.h from libiberty and build them when obstack
support is not detect on the host system.

Fixes #50

Signed-off-by: Kevin Adler [email protected]

Neither musl nor AIX (and likely other non-GNU systems) provide the
obstack interface used by anacron. To work around this, include a copy
of obstack.c and obstack.h from libiberty and build them when obstack
support is not detect on the host system.

Fixes #50

Signed-off-by: Kevin Adler <[email protected]>
@t8m
Copy link
Member

t8m commented Aug 3, 2020

I hate source code duplication of this kind but I suppose there is no other way apart from rewriting anacron to use something else. So I am merging this.
Thank you.

@t8m t8m merged commit fd934a8 into cronie-crond:master Aug 3, 2020
@kadler kadler deleted the add-obstack branch August 3, 2020 17:55
@kadler
Copy link
Contributor Author

kadler commented Aug 3, 2020

I'm not too keen on it either, but at least it's pretty isolated.

Another option would have been gnulib, but I have no idea how much work that would take to integrate - and then you have to deal with gnulib...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anacron can not be compiled on musl
2 participants