Make GitHub Actions ensure that cronie keeps compiling without errors on Linux (fixes #174) #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As for the license - pick any from the COPYING file that you prefer - or just add a copyright and refer the COPYING file for license. |
|
Otherwise the PR looks good. |
hartwork
force-pushed
the
github-actions-ci
branch
from
68fafd7
to
029b4a6
Compare
@t8m
…and Just referring to |
t8m
approved these changes
Jan 22, 2024
|
Merged. Thank you for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #174
Four things seem worth mentioning at the moment:
-std=c99and-Werrorbut the code would need related fixes first, and I wanted to keep this pull request dedicated to one thing and small enough to be easy to review.@v4inactions/checkout@v4is not pinning the GitHub Action to a SHA1 only because I seem to be rather alone with being okay with the amount of pull requests that the SHA1-plus-version-comment edition gets you. If it is considered acceptable here, I'm happy to add that pinning bit of extra security, similar to CI: Pin all GitHub Actions to specific commits for security libexpat/libexpat#709 . PS: Yes, Dependabot can still auto-bump dependencies pinned like that (which I find amazing).I'm happy to answer questions about this pull request and/or discuss adjustment of details 🍻
CC @t8m