Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Dropdown Toggle after pseudo element not present in Navbar ( Screen width > 991px ) #29

Closed
ghost opened this issue May 24, 2020 · 1 comment

Comments

@ghost
Copy link

ghost commented May 24, 2020

Version

1.1.0

Reproduction link

https://jsfiddle.net/nfktrhfm/

Operating System

MacOS

Device

MacBook Air

Browser & Version

Chrome - 81.0.4044.129

Steps to reproduce

  1. In AdminNavbar.js, from DropdownToggle remove:
    <b className="caret d-none d-lg-block d-xl-block" />

  2. Open Browser to see the dropdown in Navbar

  3. No caret is visible after user image

What is expected?

A caret should be visible automatically after dropdown-toggle in navbar without adding it explicitly.

What is actually happening?

No caret is visible even after passing caret as a prop to DropdownToggle in navbar.


Solution

  1. In _dropdown.scss, change:

.dropdown-toggle:after{ content: unset; }

to:

.navbar{ .dropdown-toggle:after{ margin-top: 10px; height: 0; } }

  1. Remove the following from AdminNavbar.js:

<b className="caret d-none d-lg-block d-xl-block" />

Additional comments

Not sure if its a bug or is intentional but comparing to other templates, it should be similar.

image

@einazare
Copy link
Contributor

Hello there, @ZephyrByte ,

Thank you for your interest in working with our products.
Yes, that is intentional.

Best,
Manu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant