Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Disable e2e and integration github actions on PRs coming from dependabot #4355

Closed
adrianriobo opened this issue Sep 11, 2024 · 4 comments

Comments

@adrianriobo
Copy link
Contributor

We are currently over testing, we can rely on check actions for the library updates to help us reduce testing cycles

@adrianriobo adrianriobo added kind/bug Something isn't working status/need triage labels Sep 11, 2024
@adrianriobo adrianriobo changed the title [QE] Disable e2e and integration github actions on PRs coming from dependabot [CI] Disable e2e and integration github actions on PRs coming from dependabot Sep 11, 2024
@rohanKanojia
Copy link
Contributor

@adrianriobo : Hello, can I work on this issue?

@rohanKanojia
Copy link
Contributor

I already see a check in e2e test pipeline to not execute for dependabot:

github.event.workflow_run.conclusion == 'success' &&
github.event.workflow_run.event == 'pull_request' &&
github.event.workflow_run.triggering_actor != 'dependabot[bot]'

Do we want to add same check in other github actions?

@adrianriobo
Copy link
Contributor Author

Ah sure, this was added to reduce the # of executions specially when provisioning machines on cloud. Definetly if you see any missing please go and filter them

@rohanKanojia
Copy link
Contributor

As discussed internally, we already have this check on Windows envs, and OpenShift CI doesn't run on the dependendabot PRs.

I think we can close this issue as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants