Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Headings are not rendered if following an unclosed comment tag (i.e. <!-- ) #63

Open
hffaust opened this issue Mar 13, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@hffaust
Copy link

hffaust commented Mar 13, 2022

Problem Background

  • I was copying down some notes from a book I was reading and I had a section of example code wrapped in the three backticks like so:
Example code line 1
Example code line 2
...
Example code line N
  • This particular code snippet happened to contain an unclosed HTML comment tag like so:
<tag 1>test tag</tag 1>
<tag 2>test tage</tag 2>
<!-- UNCLOSED COMMENT
  • I had some headings underneath that would not be rendered in the "Outline view" and it took me a while to realize that it was due to this unclosed comment tag. If I put a line with --> (note --!> does NOT work) underneath of the code box like so then I would regain functionality in the "Outline view" and I could see the rest of my headings rendered.
<tag 1>test tag</tag 1>
<tag 2>test tage</tag 2>
<!-- UNCLOSED COMMENT

-->

  • Without this line the Outline View heading rendered breaks for the remainder of the note.

Proposed Fix

  • I think there should be a way to prevent Joplin, or the Outline Renderer from trying to evaluate HTML comment tags when they are enclosed within a CODE block (i.e. between two sets of backticks).

    • This would solve the issue and make it so I do not have to add an extra nonsense line to my note to "close" the unclosed tag.
  • I am not sure if this is an issue within the Outline Plugin, or within Joplin itself...

  • I can provide screenshots if needed. Just ask. Thanks.

@cqroot cqroot added the bug Something isn't working label Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants