Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Items in bundles shift with each run of the refresh operation #353

Open
rob-reynolds opened this issue Mar 26, 2022 · 0 comments
Open

Items in bundles shift with each run of the refresh operation #353

rob-reynolds opened this issue Mar 26, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@rob-reynolds
Copy link
Collaborator

Subsequent runs of the refresh operation create phantom/false diffs in diff tools because location within the file has changed even thought the content/value hasn't.

Steps to reproduce the behavior:

  1. run the refresh operation
  2. save the resulting bundle somehow (commit to repo)
  3. run the refresh operation again, without changing anything
  4. compare the resulting file with the previous file
  5. you will see a difference even though nothing has changed because the item has shifted positions

Expected behavior
If nothing has changed the diff should not show anything has changed, i.e., the content/value should not change locations in the bundle.

Desktop (please complete the following information):

  • OS: Windows
  • Java Version: 1.8.0_311

Additional context
This can be accomplished by using ordered hashsets in java (instead of non-ordered hashsets), i.e. hashsets that guarantee the same ordering given the same hash.

@rob-reynolds rob-reynolds added the bug Something isn't working label Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant