Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid reference in MR generated from reportType=subject-list #395

Open
rob-reynolds opened this issue Dec 28, 2023 · 3 comments
Open

Invalid reference in MR generated from reportType=subject-list #395

rob-reynolds opened this issue Dec 28, 2023 · 3 comments
Labels
bug Something isn't working dQM

Comments

@rob-reynolds
Copy link

rob-reynolds commented Dec 28, 2023

IS:
Relative references in the List resources do not include the resource type.
Example:

"item": {
    "reference": "nocoverageconcern-sedconcern-sigcomp"
}

SHOULD BE:
Relative references in the List resources should include the resource type.
Example:

"item": {
    "reference": "Patient/nocoverageconcern-sedconcern-sigcomp"
}

REPRO:

  1. Run $evaluate-measure with the reportType parameter set to subject-list.
    Example:
    http:https://localhost:8000/Measure/ColorectalCancerScreeningsFHIR/$evaluate-measure?reportType=subject-list&periodStart=2024-01-01&periodEnd=2024-12-31
  2. Note the List resources in the MR contain invalid relative references.
    Example:
{
    "resourceType": "List",
    "id": "56222060-b037-4388-a20c-3d2d744b443a",
    "entry": [
        {
            "item": {
                "reference": "nocoverageconcern-sedconcern-sigcomp"
            }
        }
    ]
}

See comments for files that will generate a repro although a simpler repro is any subject-list MR.

@rob-reynolds
Copy link
Author

rob-reynolds commented Dec 28, 2023

Note: the local ("internal fragment") references in the MR are correct.
Example:
"reference": "#6d3637d3-f7a1-4c28-b717-554d90fa5398"

Testing should ensure the local references are still correct after the relative references are fixed.

@rob-reynolds rob-reynolds added the bug Something isn't working label Dec 28, 2023
@rob-reynolds
Copy link
Author

rob-reynolds commented Dec 28, 2023

All the FHIR resources needed to repro this issue (requires access to a private repo):

Once posted you can call the operation example above (http:https://localhost:8000/Measure/ColorectalCancerScreeningsFHIR/$evaluate-measure?reportType=subject-list&periodStart=2024-01-01&periodEnd=2024-12-31).

@Capt-Mac Capt-Mac added the dQM label Jan 4, 2024
@Capt-Mac
Copy link
Contributor

Capt-Mac commented Jan 4, 2024

@rob-reynolds per subject-list specification in r4 MeasureReport.

The current subject-list generates the incorrect subjectResults reference members. These should be a list of referenced MeasureReports per subject in each population per:
https://www.hl7.org/fhir/R4/measurereport-definitions.html#MeasureReport.group.population.subjectResults

currently we are only doing subjectResults with a list of patients references, which is closer to r5's subjects https://hl7.org/fhir/R5/measurereport-definitions.html#MeasureReport.group.population.subjects
, which is not supposed to be a List resource, but actually a Group.

So possibly two fixes needed here:

  1. BugFix: Update current subjectResult List to be MeasureReport not Patient resources
  2. Enhancement: Add r5 capability for subjects to show per population, referencing a Group resource with member resources = Patient with correct ResourceType identified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dQM
Projects
None yet
Development

No branches or pull requests

2 participants