Improve http tests #47
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
177b2bf
to
48094d0
Compare
jinroh
reviewed
Oct 14, 2016
| - If none is passed, the document will be force-deleted. | ||
|
|
||
| **Why shouldn't you force delete** (contrieved example) the user is syncing contacts from his mobile, a contact is created with name but no number, the user see it in the contact app. In parallel, the number is added by sync and the user click "delete" because a contact with no number is useless. The decision to delete is based on outdated data state and should therefore be aborted. | ||
| Couchdb will prevent this, the stack API allow it for fast prototyping but it should be avoided for serious applications. |
There was a problem hiding this comment.
why delete this paragraph ?
|
Added few comments but LGTM overall. |
|
Rebased and merged 5e3180b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add a lot of test on HTTP Update & Delete, and fix a few bug.
It reverts the proposal in API documentation to have the deletion works without revision provided, as it would force to make two couchdb request for every stack request.
This behaviour could later be reintroduced with a ?force=true query parameter.