Don't call setgroups unconditionally in mainrelay
#1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch moves the call to `setgroups` from the beginning of the `drop_priviliges` function to branch in which `setuid` is actually called. This still fulfills the intention of acbf7e1, initially introducting the call to `setgroups`: > Fix related to POS36-C and rpmlint error > "missing-call-to-setgroups-before-setuid". As per this intention is is not required to call `setgroups` otherwise, reducing the more exotic (as in not part of POSIX and considered priviliged by systemd) system calls coturn needs to make at startup.
|
Thank you @networkException for the contribution? |
|
You can run and see the process get killed without this patch ( I don't have a setup to test if rpmlint accepts this sadly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request moves the call to
setgroupsfrom the beginning of thedrop_priviligesfunction to branch in whichsetuidis actually called. This still fulfills the intention of acbf7e1, initially introducting the call tosetgroups:As per this intention is is not required to call
setgroupsotherwise, reducing the more exotic (as in not part of POSIX and considered priviliged by systemd) system calls coturn needs to make at startup.