-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: server/v2/stf: nil deref panic in deliverTx #20663
Labels
Comments
+1 runtime should set it. The constructor doesn't have it for some reason. |
we are still writing tests for server/v2 and other componenets in the v2 family. There will be many more things that pop up |
Merged
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there an existing issue for this?
What happened?
I was tracing through some code and I put in a panic to get a stack trace for a particular execution path. I did not know the panic I added was going to go through
(STF).deliverTx
. The STF code recovered the panic, but thens.logger.Error
caused a nil dereference panic due tos.logger
being unset. There appears to be no code path that setss.logger
This is the line that causes the nil dereference:
cosmos-sdk/server/v2/stf/stf.go
Line 173 in 55b0093
This panic would have shown up in test if the recover path were covered.
Cosmos SDK Version
main
How to reproduce?
No response
The text was updated successfully, but these errors were encountered: