[Bug]: server/v2/stf: nil deref panic in deliverTx

[mark-rushakoff]

Is there an existing issue for this?

• I have searched the existing issues

What happened?

I was tracing through some code and I put in a panic to get a stack trace for a particular execution path. I did not know the panic I added was going to go through (STF).deliverTx. The STF code recovered the panic, but then s.logger.Error caused a nil dereference panic due to s.logger being unset. There appears to be no code path that sets s.logger

This is the line that causes the nil dereference:

cosmos-sdk/server/v2/stf/stf.go

Line 173 in 55b0093

s.logger.Error("panic during transaction execution", "error", recoveryError)

This panic would have shown up in test if the recover path were covered.

Cosmos SDK Version

main

How to reproduce?

No response

[julienrbrt]

+1 runtime should set it. The constructor doesn't have it for some reason.

[tac0turtle]

we are still writing tests for server/v2 and other componenets in the v2 family. There will be many more things that pop up