-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(blockgas): remove block gas #19793
Comments
[feature request] along with removing block gas meter, add |
Hey @tac0turtle, Just for clarification when you say removing the |
when does this run? |
gasmeter stays |
End blocker |
Happy to remove the block gas meter! |
another thing to be careful is, it's only safe to remove block gas meter if we check the sum of gas wanted in the process proposal handler, which is only the case when we use the SDK mempool, AFAIK |
Removing the Block gas meter from the context would be nice to have a smaller footprint on the modules. Within the SDK it would not be hard as gas is consumed in
I did not look into other projects so there can be more use cases. Nevertheless we may be able to move this forward by providing the same functionality in a different way. I was also wondering if there is any reason to fail so late on block gas. IMHO it makes sense to check |
look into removing blockgas from context and gas service.
It is used in upgrade but i dont see us consuming gas there.
The text was updated successfully, but these errors were encountered: