Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcut only works on origin tab #2

Open
alexllg opened this issue Feb 13, 2023 · 1 comment
Open

Shortcut only works on origin tab #2

alexllg opened this issue Feb 13, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@alexllg
Copy link

alexllg commented Feb 13, 2023

The shortcut only works if the tab that's being active or opened is the one playing the video. I'm trying to use discord on another tab (I don't want to use the desktop version) and youtube on the other. If I press ctrl+period on the discord tab, it doesn't work, it doesn't show or hide the PiP, it only works if I'm on youtube tab.

@corbindavenport corbindavenport changed the title Only works if you're on the tab where the video is playing Shortcut only works on origin tab Feb 13, 2023
@corbindavenport corbindavenport added the bug Something isn't working label Feb 13, 2023
@corbindavenport
Copy link
Owner

Changing PiP state in other tabs would require additional permissions, indexing all tabs to check which one has the audible property, and then injecting code into that specific page. I'm not sure if that's possible under Manifest V3 without granting permission to all sites, I'll have to do some testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants