-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] No warning or error when no eval samples provided #23
Comments
It should probably crash and if people want to train without eval samples, they can skip it with |
Not sure where to raise the error though. If we put it in the But if we check after the get_eval_dataloader here, when no eval sample are provided it can crash if the
Where should we do this in your mind @erogol ? |
maybe we can use an empty list as the default for the samples and check the data loader size. If it is zero, raise an error. |
We'd still have the same problem, since item[0] would raise out if range right? |
Describe the bug
👟 needs to raise an error when there is no eval sample or skip the eval step.
👉 coqui-ai/TTS#1447
To Reproduce
coqui-ai/TTS#1447
Expected behavior
Raise an error " [!] No eval samples provided"
Or skip the eval step
Logs
No response
Environment
Additional context
No response
The text was updated successfully, but these errors were encountered: