Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] VITS model needs its own AudioConfig class #1474

Closed
erogol opened this issue Apr 5, 2022 · 1 comment
Closed

[Bug] VITS model needs its own AudioConfig class #1474

erogol opened this issue Apr 5, 2022 · 1 comment
Assignees
Labels
bug Something isn't working wontfix This will not be worked on but feel free to help.

Comments

@erogol
Copy link
Member

erogol commented Apr 5, 2022

🐛 Description

Some of the fields in BaseAudioConfig are not used in VITS models and it is misleading.

This was also the reason for our silence issues when training our latest VITS models @Edresson

To Reproduce

You can set for instance silence trimming True but it would not work since VITS uses a custom load_audio function without
silence trimming.

Expected behavior

I've 3 solutions

  1. VITSAudioConfig
  2. Raise an error when a field in BaseAudioConfig is not being used (probably harder )
  3. Find a smart way to override AudioProcessor instead of writing custom standalone functions.
@erogol erogol added the bug Something isn't working label Apr 5, 2022
@e0xextazy
Copy link

Has this problem been solved?

@stale stale bot added the wontfix This will not be worked on but feel free to help. label May 18, 2022
@stale stale bot closed this as completed May 26, 2022
@coqui-ai coqui-ai deleted a comment from stale bot May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on but feel free to help.
Projects
None yet
Development

No branches or pull requests

4 participants