Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: System Wide GitHub Apps does not work #2643

Open
iamEvanYT opened this issue Jun 23, 2024 · 3 comments
Open

[Bug]: System Wide GitHub Apps does not work #2643

iamEvanYT opened this issue Jun 23, 2024 · 3 comments

Comments

@iamEvanYT
Copy link
Contributor

iamEvanYT commented Jun 23, 2024

Description

image
After I set the GitHub app to system wide, it does not appear on my other teams.

Minimal Reproduction (if possible, example repository)

  1. Create a GitHub App
  2. Enable the System Wide option
  3. Go to another team
  4. It does not show in other teams.

Exception or Error

Looking into the code, this function should be where the bug is.

coolify/app/Models/Team.php

Lines 188 to 196 in de7380f

public function sources()
{
$sources = collect([]);
$github_apps = $this->hasMany(GithubApp::class)->whereisPublic(false)->get();
$gitlab_apps = $this->hasMany(GitlabApp::class)->whereisPublic(false)->get();
$sources = $sources->merge($github_apps)->merge($gitlab_apps);
return $sources;
}

Version

v4.0.0-beta.297

@ari-party
Copy link
Contributor

Reproduced it on v4.0.0-beta.315

@iamEvanYT
Copy link
Contributor Author

@andrasbacsai any updates?

@sandros94
Copy link

Also on v4.0.0-beta.329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants