-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Unable to specify Redis AOF #2637
Comments
@ladderschool I am implementing this. Is the following behavior what you are looking for?
|
Draft
Sorry for the late reply, I've been busy with work. That's exactly what I would expect, yes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
When creating a Redis resource from Coolify the docker-compose.yaml sets the following command:
The problem is that it adds --appendonly yes after the redis.conf is read. This means, if you set "appendonly no" in your redis.conf it will have no effect. Essentially, the DX suffers because you can't control if you want persistence or not. You must always have persistence. This is not necessary and I recommend removing the --apendonly yes to the redis-server startup in the docker compose file. Allow the developer to choose if they want AOF by using the redis.conf. Equally, it would be beneficial if the developer could set the --requirepass value, there is also a setting in the redis.conf for this. Overall, I suggest redis.conf > startup arguments for a better DX.
Minimal Reproduction (if possible, example repository)
Go to your Coolify server and create a new Redis resource. Try to use appendonly no in your redis.conf and delete the appendonlydir. Restart the Redis and watch how it recreates the appendonlydir and neglects your appendonly no configuration in the redis.conf
Exception or Error
N/A
Version
v4.0.0-beta.297
The text was updated successfully, but these errors were encountered: