Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI flake: secret file is not leaked into image #13417

Closed
edsantiago opened this issue Mar 3, 2022 · 5 comments · Fixed by #13457 or #14485
Closed

CI flake: secret file is not leaked into image #13417

edsantiago opened this issue Mar 3, 2022 · 5 comments · Fixed by #13457 or #14485
Assignees
Labels
flakes Flakes from Continuous Integration locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote

Comments

@edsantiago
Copy link
Member

Pretty rare flake:

? Failure [10.262 seconds]
    Podman build
    /var/tmp/go/src/github.com[/containers/podman/test/e2e/build_test.go:18](https://github.com/containers/podman/blob/572e6464f607189744afb76ee729ab31018266ad/test/e2e/build_test.go#L18)
      podman build with a secret from file and verify if secret file is not leaked into image [It]
      /var/tmp/go/src/github.com[/containers/podman/test/e2e/build_test.go:85](https://github.com/containers/podman/blob/572e6464f607189744afb76ee729ab31018266ad/test/e2e/build_test.go#L85)
         
      Expected
          <string>: Containerfile Containerfile.path Containerfile.volume Dockerfile
                    Dockerfile.squash-a Dockerfile.squash-b Dockerfile.squash-c Dockerfile.test-cp-root-dir
                    Dockerfile.with-multiple-secret Dockerfile.with-secret Dockerfile.with-secret-verify-leak
                    alpinetest.tgz anothersecret.txt bin context_dir_a_file dev etc home lib media mnt opt
      >>>>>>>>>>>>> podman-build-secret535923765 podman-build-secret775430160 podman-build-secret893804089
                    proc root run sbin secret.txt srv sys tmp usr var
      not to contain substring
          <string>: podman-build-secret
         
      test/e2e/build_test.go#L94

(formatted for legibility).

This is ginkgo, so my hunch is that multiple secrets-related tests are all running at once. One super-simple fix might be to move test/e2e/build/Dockerfile.with-secret-verify-leak into a new subdirectory, test/e2e/build/secret-verify-leak. It should be very easy to do this and see if the flake goes away. But it's also possible that this is a real bug.

Seems to be remote only.

Podman build [It] podman build with a secret from file and verify if secret file is not leaked into image

@edsantiago edsantiago added flakes Flakes from Continuous Integration remote Problem is in podman-remote labels Mar 3, 2022
@github-actions github-actions bot removed the remote Problem is in podman-remote label Mar 3, 2022
@vrothberg
Copy link
Member

@ashley-cui please take a look

@edsantiago
Copy link
Member Author

@edsantiago edsantiago reopened this May 10, 2022
@vrothberg
Copy link
Member

@ashley-cui can you take a look?

@edsantiago
Copy link
Member Author

Podman build [It] podman build with a secret from file and verify if secret file is not leaked into image

@edsantiago edsantiago added the remote Problem is in podman-remote label Jun 2, 2022
@ashley-cui
Copy link
Member

Ahh! Forgot about this, taking another look now

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
flakes Flakes from Continuous Integration locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote
Projects
None yet
3 participants