Bump the version to the initial dev for the new c/common
v0.59 release branch.

Signed-off-by: tomsweeneyredhat <[email protected]>

[v0.59.0] Bump c/common to v0.59.1-dev

Packit failed to trigger an automatic fedora package update on the
upstream release v0.59.0 which brought to light further issues which
this commit corrects.

Packit doesn't honor a global `downstream_package_name` key when the
upstream repo and downstream package name don't match. For this very
repo, upstream repo is `common`, while downstream package is
`containers-common`. For such cases, `downstream_package_name`
should be specified at the package level.

The `Source0` URL in rpm spec has also been corrected. This wasn't noticed
in packit jobs on PRs because packit replaces Source0 with a locally
created archive.

The `mv` commands in rpm spec have also been replaced by `cp` so that
consecutive `rpmbuild` runs will not complain about not finding the
source files.

The autosetup step in rpm spec has also been updated to the correct
untarred archive name format.

Misc cleanup includes removal of `update_release: false` from downstream
jobs. It's meaningless in those jobs. Even for copr jobs, we should
prefer packit's default behavior of `update_release: true`.

Signed-off-by: Lokesh Mandvekar <[email protected]>
(cherry picked from commit 3c96617)
Signed-off-by: Lokesh Mandvekar <[email protected]>

[v0.59 backport] [skip-ci] Packit/RPM: more fixes

This commit copies over shortnames.conf, registries.conf
and storage.conf to the rpm build dir before running the patching
script.

Prior to this, the script would complain about not finding those files
but the rpmbuild process itself didn't fail.

Signed-off-by: Lokesh Mandvekar <[email protected]>
(cherry picked from commit 06a4eef)
Signed-off-by: Lokesh Mandvekar <[email protected]>

[v0.59 backport] [skip-ci] RPM: ensure config files are patched

The rpm creates and installs to dirs /usr/share/rhel and
/usr/lib/containers . So, it should own them as well.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2283290

Signed-off-by: Lokesh Mandvekar <[email protected]>
(cherry picked from commit c7070a9)
Signed-off-by: Lokesh Mandvekar <[email protected]>

nftables was implemented for netavark v1.10

Signed-off-by: Paul Holzinger <[email protected]>

For some unknown reason the podman container image sets the
_CONTAINERS_USERNS_CONFIGURED env to an empty value. I don't know what
the purpose of this is but is will trigger the check here which is wrong
when the container is privileged.

To fix this check that the value is set to done like it is by the reexec
logic. Also make sure the lock dir uses the same condition to stay
consistent.

Fixes containers/podman#22791

Signed-off-by: Paul Holzinger <[email protected]>

When asked to add all of the entries from one index to another, don't
forget to carry over the artifactType.

Signed-off-by: Nalin Dahyabhai <[email protected]>

[v0.59 backport] [skip-ci] RPM: own dirs

The path no longer included the path separator between the env and our
config dir. The regression was added in commit 6c651df.

Fixes #2025

Signed-off-by: Paul Holzinger <[email protected]>

[v0.59] more backports

As the title says.  In preparation for Podman v5.1.1

Signed-off-by: tomsweeneyredhat <[email protected]>