-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nerdctl login
should warn about passing along an explicit scheme
#3052
Comments
nerdctl login
should warn about passing along an explicit scheme and should ignore it entirelynerdctl login
should warn about passing along an explicit scheme
Hi @apostasie, |
@fahedouch any user specified scheme in the url is just ignored entirely. Try for example: The fact that we fallback from https to http (typically through --insecure-registry) is orthogonal. |
It looks like a bug. It is not the intended behavior. Let me check this. |
Description
While
pull
andpush
do not allow explicit schemes (as image identifiers do not), both docker and nerdctllogin
DO allow it, albeit ignoring them entirely.Our suggestion is to:
This will impact #3046 - which I believe still matters as there should be a way to talk TLS even with localhost.
Steps to reproduce the issue
Describe the results you received and expected
What version of nerdctl are you using?
1.7.6
Are you using a variant of nerdctl? (e.g., Rancher Desktop)
None
Host information
No response
The text was updated successfully, but these errors were encountered: