Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use images for social meta tags #2197

Closed
decabeza opened this issue Dec 15, 2017 · 1 comment · Fixed by #2202
Closed

Use images for social meta tags #2197

decabeza opened this issue Dec 15, 2017 · 1 comment · Fixed by #2202
Assignees
Milestone

Comments

@decabeza
Copy link
Collaborator

Background

Now when a user share a CONSUL's page by default shows a general image.

Share on Facebook

facebook

Share on Twitter

twitter

What

If the user has uploaded an image to their proposal or budget investment show this image when share on social networks instead of default image.

How

On proposals/show.html.erb:

  • Adds twitter_image_url and og_image_url properties on render "shared/social_media_meta_tags" (only if proposal image is present)

On investments/_investment_show.html.erb:

  • Adds shared/social_media_meta_tags partial (use proposal as reference)

  • Adds twitter_image_url and og_image_url properties on render "shared/social_media_meta_tags" (only if investment image is present)

@aitbw
Copy link
Collaborator

aitbw commented Dec 18, 2017

I'll handle this.

@decabeza decabeza added this to Doing in Roadmap Dec 18, 2017
@voodoorai2000 voodoorai2000 moved this from Doing to Done in Roadmap Jan 3, 2018
@bertocq bertocq added this to the v0.13 milestone Jan 4, 2018
@MariaCheca MariaCheca moved this from Done to Review in Roadmap Jan 8, 2018
@voodoorai2000 voodoorai2000 moved this from Review to Done in Roadmap Jan 8, 2018
@voodoorai2000 voodoorai2000 removed this from Done in Roadmap Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants